aesara icon indicating copy to clipboard operation
aesara copied to clipboard

Add Windows to CI tests

Open maresb opened this issue 2 years ago • 2 comments

For background see #980. This is currently incomplete since the scripts need to be adapted to be Windows-compatible.

I don't plan to complete this, so this is for reference in hopes that someone else takes over this task.

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • [ ] There is an informative high-level description of the changes.
  • [ ] The description and/or commit message(s) references the relevant GitHub issue(s).
  • [ ] pre-commit is installed and set up.
  • [ ] The commit messages follow these guidelines.
  • [ ] The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • [ ] There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

maresb avatar Jul 02 '22 10:07 maresb

Closes #1028

maresb avatar Jul 02 '22 10:07 maresb

To first introduce Windows tests, we need to restrict them to only a single matrix.include; otherwise, we balloon the test matrix with long-running tests with too much redundant coverage. In other words, we really need to restrict Windows test coverage to Windows-specific code paths.

brandonwillard avatar Jul 06 '22 23:07 brandonwillard