aerospike-client-rust icon indicating copy to clipboard operation
aerospike-client-rust copied to clipboard

Fixed large integers packing when encoding to messagepack

Open bmuddha opened this issue 2 years ago • 4 comments

Closes #115

bmuddha avatar Feb 24 '22 05:02 bmuddha

Thanks for your PR. Could you please include a test case to make sure the issue doesn't creep back into the code base in the future?

khaf avatar Feb 24 '22 17:02 khaf

Thanks for your PR. Could you please include a test case to make sure the issue doesn't creep back into the code base in the future?

Done, added new test case for query with filter on large i64 value

bmuddha avatar Feb 25 '22 07:02 bmuddha

Could you please revert the write confirmation removal? Writes are not fire and forget and the server may return meaningful errors.

khaf avatar Mar 07 '22 16:03 khaf

Oops, I'm really sorry, it slipped through when I was experimenting on my own project, reverted it back

bmuddha avatar Mar 07 '22 17:03 bmuddha