aerogear-unifiedpush-server icon indicating copy to clipboard operation
aerogear-unifiedpush-server copied to clipboard

[WIP] hardcode dev apis

Open briangallagher opened this issue 3 years ago • 2 comments

Motivation

Add references to relevant tickets or a short description about what motivated you do it. (E.g JIRA: https://issues.jboss.org/browse/AEROGEAR-{} AND/OR ISSUE: https://github.com/aerogear/standards/issues/{})

What

Add an short answer for: What was done in this PR? (E.g Don't allow users has access to the feature X.)

Why

Add an short answer for: Why it was done? (E.g The feature X was deprecated.)

How

Add an short answer for: How it was done? (E.g By removing this feature from ... OR By removing just the button but not its implementation ... )

Verification Steps

Add the steps required to check this change. Following an example.

  1. Go to XX >> YY >> SS
  2. Create a new item N with the info X
  3. Try to edit this item
  4. Check if in the left menu the feature X is not so long present.

Checklist:

  • [ ] Code has been tested locally by PR requester
  • [ ] Changes have been successfully verified by another team member

Progress

  • [x] Finished task
  • [ ] TODO

Additional Notes

PS.: Add images and/or .gifs to illustrate what was changed if this pull request modifies the appearance/output of something presented to the users.

briangallagher avatar Mar 29 '21 20:03 briangallagher

-1, this value is already hardcoded in the pushy api that you are replacing

https://pushy-apns.org/apidocs/0.14/constant-values.html#com.turo.pushy.apns.ApnsClientBuilder.DEVELOPMENT_APNS_HOST

secondsun avatar Mar 30 '21 13:03 secondsun

Sorry, just saw it was a WIP, reopening

secondsun avatar Mar 30 '21 13:03 secondsun