statamic-factory icon indicating copy to clipboard operation
statamic-factory copied to clipboard

Feature/#8 imported fieldsets

Open Lenitr opened this issue 3 years ago • 4 comments
trafficstars

For #8, I first tried simply adding some fixes so the fieldsets will be ignored.

I'm not entirely familiar with the codebase of Statamic yet, but I figured out with a bit of trial and error to actually fetch the fields that are set in the fieldsets and map them as well, so factory for fieldsets can also be supported.

I tried reusing the same recursive structure you already made, so if there's any special fields used within a fieldset it should still work as it used to (like a Replicator field within a fieldset for example).

Lenitr avatar Jul 01 '22 12:07 Lenitr

I've given this a closer look and I think this should to be approached from a different angle. I started working on a bigger refactor.

aerni avatar Jul 01 '22 21:07 aerni

How's it going so far? Running into any issues?

Lenitr avatar Jul 22 '22 08:07 Lenitr

I started working on the refactor. But haven't had time to complete it. If you can't wait, you can always pull this PR into your project in the meantime.

aerni avatar Jul 22 '22 13:07 aerni

Ok good to know, take your time.

I already pulled the code in my own project, so I'm not in a hurry, no worries ;)

Lenitr avatar Jul 22 '22 14:07 Lenitr

Imported fieldsets will work with the next major release.

aerni avatar Aug 28 '24 20:08 aerni