aerisjs icon indicating copy to clipboard operation
aerisjs copied to clipboard

Radar Animations stopped working with google maps

Open monkburger opened this issue 10 years ago • 5 comments

I've been using the same code for awhile, but I haven't looked at it since June.

Radar animations do not seem to work at all with any of my existing code, but I can kind of get a static, non radar image to function.

Please see [URL HIDDEN]

Did I miss something? I'm pretty sure I never changed anything.

monkburger avatar Oct 08 '14 10:10 monkburger

Hi @monkburger I've confirmed that there is a bug in the animation layer loading when using google maps (it works fine using Leaflet, which is why I didn't notice anything on the demo page).

I'm going to try and track this down, and hopefully we can push out a hotfix today.

eschwartz avatar Oct 08 '14 13:10 eschwartz

My strategy for preloading layer tile images was not working for Google Maps. I refactored the preload logic, and have a v0.7.16 release going through QA right now. I'll let you know when it's deployed.

eschwartz avatar Oct 08 '14 16:10 eschwartz

Thank you for quickly tracking down the issue.

monkburger avatar Oct 08 '14 20:10 monkburger

There seems to be some animation regression on google maps, perhaps not with your change, but I cannot isolate it.

The frame animations are not being consistent between what JS is pulling from the server and what is on the screen. For example:

radarimg1 radarimg2 radarimg3 <---inconsistency----> radarimg4 radarimg5 <--inconsistency-----> .. etc..

It almost seems like the inconsistent radar is a blank(?) image and it it's causing a total radar blackout for at least a timeperiod.

I've tried this with and without the example preload code.

For example, it seems to work great here:

http://jsfiddle.net/zCr2f/10/ But not on the test URL above which is basically your example code with some more additions (markers).

EDIT:

With the following, it shows the radar image transition is not smooth/consistent compared to Leaflet and has some transistion issues between the current frame and the next frame (using http://cdn.aerisjs.com/aeris-gmaps-plus.min.js)

    radar = new aeris.maps.layers.Radar();
    radarAnim = new aeris.maps.animations.TileAnimation(radar);
    radar.setMap(map);
    radarAnim.start();

monkburger avatar Oct 09 '14 04:10 monkburger

Hmm... I've been playing around with it a bit more, and I've found that sometimes (often) the animation will not preload all the way to 100% while it's running. In addition, I may have introduced a bug in the hotfix which causes not-yet-loaded layers to be displayed, causing an "empty frame" in the animation.

The empty frame issue will be fixed in the next few days. I'm not sure about the preloading issue -- I'll have to look into that a bit closer. In the meantime, I would suggest that you fully preload the animation before starting.

animation.preload().
  done(function() {
    animation.start();
  });

This seemed to fix the stalled preloading issue for me

eschwartz avatar Oct 09 '14 14:10 eschwartz