aep.dev icon indicating copy to clipboard operation
aep.dev copied to clipboard

use numeric slug for linking

Open earth2marsh opened this issue 5 months ago • 5 comments

While our link was using the numeric slug, the link text was using a pattern that resulted in a 404. This switches to use the numeric slug.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes that apply

  • [ ] Enhancement
  • [ ] New proposal
  • [ ] Migrated from google.aip.dev
  • [x] Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for contributing to this repository.

General

earth2marsh avatar Aug 06 '25 22:08 earth2marsh

@rambleraptor , I think we moved to numeric slugs without a text-based alias? All I know is that the guidance was suggesting a text-based URL that was resulting in 404s.

earth2marsh avatar Aug 06 '25 22:08 earth2marsh

Hmm, if this change is correct, than I think perhaps https://aep.dev/tooling/linter/rules/0162/ may need an update, too?

I see this guidance does still refer to word-based slugs, so possibly that deserves attention?

earth2marsh avatar Aug 06 '25 22:08 earth2marsh

@toumorokoshi

I think we're trying to use the non-numeric slugs. Both of them should work regardless.

rambleraptor avatar Aug 06 '25 23:08 rambleraptor

@rofrankel too

rambleraptor avatar Aug 07 '25 01:08 rambleraptor

I think in this particular case we shouldn't update those - that should probably always point at not-precdent in case that aep is updated.

But those are examples, correct? so really it comes down to whether the linter accepts them (I presume it does).

toumorokoshi avatar Aug 08 '25 17:08 toumorokoshi