aep.dev icon indicating copy to clipboard operation
aep.dev copied to clipboard

feat(update): remove create or update

Open toumorokoshi opened this issue 1 year ago • 2 comments

create or update introduces a new pattern in addition to the existing flow of:

  1. getting a resource.
  2. if NOT_FOUND, send a create.
  3. if found, send an update.

In the future, this could be re-added as an Apply method, which would map to the appropriate REST method of PUT.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes that apply

  • [x] Enhancement
  • [ ] New proposal
  • [ ] Migrated from google.aip.dev
  • [ ] Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for contributing to this repository.

General

💝 Thank you!

toumorokoshi avatar Sep 14 '24 03:09 toumorokoshi

I'm in favor of this as long as the goal is to add an Apply method. If we don't add Apply long-term, this feels useful.

rambleraptor avatar Sep 14 '24 03:09 rambleraptor

Feedback offline from @rofrankel is to wait until apply is merged (issue tracked in #110)

toumorokoshi avatar Sep 23 '24 16:09 toumorokoshi

blocked on #248 - once that is merged, this will also merge.

toumorokoshi avatar Nov 13 '24 06:11 toumorokoshi