aep.dev icon indicating copy to clipboard operation
aep.dev copied to clipboard

Should this be a versioned reference?

Open rofrankel opened this issue 1 year ago • 3 comments
trafficstars

          Should this be a versioned reference?

Originally posted by @gibson042 in https://github.com/aep-dev/aep.dev/pull/173#discussion_r1577164619

rofrankel avatar Apr 26 '24 18:04 rofrankel

I don't know if it makes sense for aep.dev/filtering to point to a specific version of the CEL spec - to me, that would imply that the AEPs have opinions about specific details of CEL versions, and I'm not sure that they should.

I guess CEL 2.0 could come out with breaking changes? But if that happens, then A) hopefully it doesn't break the non-versioned link; and B) I'm not sure we want to tell people to stay on CEL 1.0 by default forever anyway.

WDYT?

rofrankel avatar Apr 26 '24 18:04 rofrankel

No matter what, I think each API must document specifics of what it supports, which would need to include this detail in the event of a backwards-incompatible CEL 2 (and if the API supports both versions, then we'd be looking at adding something like a filterLanguage field for conveying the interpretation of filter). But since language restrictions are already permitted anyway, cross-API portability is not guaranteed so I think I agree that the AEP-level references do not need to be versioned.

gibson042 avatar Apr 29 '24 15:04 gibson042

So AFAICT, no changes are needed at the moment.

gibson042 avatar Apr 29 '24 15:04 gibson042