aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] Parallelize SAX and PAA transformers

Open aadya940 opened this issue 4 months ago • 10 comments

Related to #2972

aadya940 avatar Jul 31 '25 09:07 aadya940

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ enhancement ]. I have added the following labels to this PR based on the changes made: [ transformations ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run mypy typecheck tests
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [ ] Disable numba cache loading
  • [ ] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Jul 31 '25 09:07 aeon-actions-bot[bot]

Nice addition @aadya940 !

Could you run examples comparing the old and new code in terms of output accuracy ? to make sure the algorithm didnt change Also can we benchmark the time gain ? like see how faster it becomes as plot in function of n samples length of the series etc.

hadifawaz1999 avatar Jul 31 '25 11:07 hadifawaz1999

@hadifawaz1999 Yes sure

aadya940 avatar Jul 31 '25 12:07 aadya940

nothing is dead code @aadya940 :) just probably inconsistent usage of prange, but code works fine

hadifawaz1999 avatar Jul 31 '25 16:07 hadifawaz1999

@hadifawaz1999 By dead code I meant it has no effect on the output and gives identical results in terms of speed and accuracy to if there was a single prange since numba ignores other nested prange :)

aadya940 avatar Jul 31 '25 16:07 aadya940

@hadifawaz1999 By dead code I meant it has no effect on the output and gives identical results in terms of speed and accuracy to if there was a single prange since numba ignores other nested prange :)

if am not mistaken numba considers a prange as a normal range when its nested, so its simply useless usage of prange nested yes

hadifawaz1999 avatar Jul 31 '25 16:07 hadifawaz1999

LGTM! The changes suggested have been made.

aadya940 avatar Sep 22 '25 02:09 aadya940

@baraline Any updates here?

aadya940 avatar Nov 09 '25 19:11 aadya940

Will take a look tomorrow

baraline avatar Nov 09 '25 19:11 baraline

The inverse is parallelised for PAA but not SAX, any reason for that?

MatthewMiddlehurst avatar Nov 10 '25 20:11 MatthewMiddlehurst