[BUG] Fix RDST admissible sampling point method

[baraline]

Reference Issues/PRs

Fixes #2759

What does this implement/fix? Explain your changes.

Fix shapelet sampling point method returning the id of the choice, and not the timestamp linked to the id of the choice.

Any other comments?

See #2759 for performance comparison.

For all contributions

• [X] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
• [X] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

[aeon-actions-bot[bot]]

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

• [ ] Run pre-commit checks for all files
• [ ] Run mypy typecheck tests
• [ ] Run all pytest tests and configurations
• [ ] Run all notebook example tests
• [ ] Run numba-disabled codecov tests
• [ ] Stop automatic pre-commit fixes (always disabled for drafts)
• [ ] Disable numba cache loading
• [ ] Push an empty commit to re-run CI checks

[baraline]

Expected results seem to differ for some test configurations, not sure why yet

[MatthewMiddlehurst]

Happy to review when its resolved.

[baraline]

I'm currently clueless about why these fails, I cannot seem to reproduce the issue on my Ubuntu either ... If anyone has any leads, I'd be grateful, otherwise i'll come back to this to do some bug hunting later.

[baraline]

I think I found the issue. I was using a NumPy random Generator numba inside a parallel loop, but the use of such a generator is not thread-safe according to numba documentation. I changed the code to spawn new generators for each loop, and it looks like it fixed it.