aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[DEP] Removes `_binary.py' (1.2.0)

Open aryanpola opened this issue 7 months ago • 3 comments

Reference Issues/PRs

Fixes a part of #2576

What does this implement/fix? Explain your changes.

Removes the deprecated functions and deletes the file _binary.py, newer versions of the functions are available at aeon/benchmarking/metrics/anomaly_detection/range_metrics.py. Also removes the dependent test cases from test_ad_metrics.py.

Any other comments?

Should be removed in Version 1.2.0

aryanpola avatar Apr 14 '25 13:04 aryanpola

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#BDD9DB}{\textsf{refactor}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#264F59}{\textsf{benchmarking}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run mypy typecheck tests
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [ ] Disable numba cache loading
  • [ ] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Apr 14 '25 13:04 aeon-actions-bot[bot]

@MatthewMiddlehurst There are functions that use prts package in aeon/benchmarking/metrics/anomaly_detection/_continuous.py, would you like me to update them with newer version functions? Will push them here.

aryanpola avatar Apr 14 '25 14:04 aryanpola

No keep this focused. If you want you can create a different PR.

MatthewMiddlehurst avatar Apr 17 '25 21:04 MatthewMiddlehurst

Will be closing this, since the necessary changes are done in #2781

aryanpola avatar May 20 '25 12:05 aryanpola