aeon
aeon copied to clipboard
[ENH] Adding type hinting for files: aeon/benchmarking/*
Reference Issues/PRs
Fixes #1454 some part
What does this implement/fix? Explain your changes.
I have added type hinting in the files. For this I also needed to import from typing such as List, Union etc. I have added hints just in the parameter of some functions in the python files.
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
I will work on some other folders if this PR gets done. I am new to Open Source. This is my first contribution and I loved it. Thanks.
PR checklist
For all contributions
- [ ] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
- [x] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
Thank you for contributing to aeon
I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#264F59}{\textsf{benchmarking}}$ ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon Slack channel if you have any.
PR CI actions
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
- [ ] Run
pre-commitchecks for all files - [ ] Run
mypytypecheck tests - [ ] Run all
pytesttests and configurations - [ ] Run all notebook example tests
- [ ] Run numba-disabled
codecovtests - [ ] Stop automatic
pre-commitfixes (always disabled for drafts) - [ ] Disable numba cache loading
- [ ] Push an empty commit to re-run CI checks
@baraline @MatthewMiddlehurst @hadifawaz1999 @TonyBagnall Could you please review this PR? I have addressed all the necessary changes. Thanks!