aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] Adapt the DCNN Networks to use Weight Norm Wrappers

Open aadya940 opened this issue 8 months ago • 2 comments

Apply weight norm wrappers and remove L2 Regularization.

Closes #1714

aadya940 avatar Mar 16 '25 09:03 aadya940

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#379E11}{\textsf{networks}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run mypy typecheck tests
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [ ] Disable numba cache loading
  • [ ] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Mar 16 '25 09:03 aeon-actions-bot[bot]

@hadifawaz1999 LGTM!

aadya940 avatar Mar 16 '25 12:03 aadya940

Hey @hadifawaz1999 , This layer doesn't work well with Conv1DTranspose, I think thats because our _WeightNormalization wrapper internally uses tf.nn.conv1d.

aadya940 avatar May 11 '25 17:05 aadya940

oh okay i see i see, originally conv transposes were not yet a thing so they didnt have an issue. Lets get this in then and we'll think of a solution for later.

hadifawaz1999 avatar May 11 '25 18:05 hadifawaz1999