aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] DTW AROW implementation

Open tanishy7777 opened this issue 8 months ago • 7 comments

Reference Issues/PRs

Fixes #751

What does this implement/fix? Explain your changes.

This PR aims to add DTW AROW algorithm, which is a modification of the DTW distance metric, that locally finds the best alignment between two time series that may have some missing values.

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

PR checklist

For all contributions
  • [x] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • [x] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • [ ] I've added the estimator/function to the online API documentation.
  • [ ] (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • [ ] (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

tanishy7777 avatar Mar 14 '25 18:03 tanishy7777

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#5209C9}{\textsf{distances}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run mypy typecheck tests
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [ ] Disable numba cache loading
  • [ ] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Mar 14 '25 18:03 aeon-actions-bot[bot]

I have compared the results against the implementation here https://github.com/aras-y/DTW_with_missing_values Which has one of the original authors from the paper as a contributor

image

Zoomed in version image

tanishy7777 avatar Mar 23 '25 18:03 tanishy7777

Equivalence of original implementation and my implementation for a few other cases(from test_distances.py) Note: The original implementation dosen't support unequal no of channels thats why 1 extra output in the image for my implementation

image

image

tanishy7777 avatar Apr 16 '25 19:04 tanishy7777

Equivalence for cost matrix and alignment path

image image

tanishy7777 avatar Apr 16 '25 19:04 tanishy7777

Thanks. Currently the functions are not suitably documented and the top file comment seems to be incorrect. Please look at other files for some examples

MatthewMiddlehurst avatar Apr 30 '25 16:04 MatthewMiddlehurst

Thanks. Currently the functions are not suitably documented and the top file comment seems to be incorrect. Please look at other files for some examples

Np! Will fix this soon.

tanishy7777 avatar May 02 '25 00:05 tanishy7777

Hi, any progress on this?

MatthewMiddlehurst avatar Aug 14 '25 10:08 MatthewMiddlehurst