aeon icon indicating copy to clipboard operation
aeon copied to clipboard

Published 20 hours ago • verified publisher icon aeon-toolkit

[ENH] Removing `prts` related files

Open aryanpola opened this issue 9 months ago • 5 comments

Related PR #2400

  • [x] Deprecate the older functions.

  • [x] Update the tests. They should compare the hard-coded values with the new implementation output.

  • [ ] Remove the older functions from aeon\benchmarking\metrics\anomaly_detection\_binary.py that use prts as a dependency and remove the test cases using _binary functions.

  • [ ] Remove prts from all_extras.

aryanpola avatar Feb 26 '25 13:02 aryanpola

@aeon-actions-bot assign @aryanpola

aryanpola avatar Feb 26 '25 13:02 aryanpola

@aryanpola Can i work on this part?

Sharathchenna avatar Feb 28 '25 13:02 Sharathchenna

As these are part of benchmarking, they must be deprecated first. Please read our deprecation guide if you want to do this yourself.

MatthewMiddlehurst avatar Mar 03 '25 22:03 MatthewMiddlehurst

@MatthewMiddlehurst Since the older functions will be removed in the upcoming version, would a single PR addressing the deprecation of functions from aeon\benchmarking\metrics\anomaly_detection\_binary.py be sufficient for now?

Also, would you like me to address in a new PR or the existing PR (#2400 )?

aryanpola avatar Mar 04 '25 22:03 aryanpola

I would do it in a new PR

MatthewMiddlehurst avatar Mar 08 '25 15:03 MatthewMiddlehurst

@MatthewMiddlehurst I think everything is ready to remove the prts dependency now.

SebastianSchmidl avatar May 23 '25 14:05 SebastianSchmidl