aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] Test coverage for AEAttentionBiGRUNetwork Improved

Open lucifer4073 opened this issue 9 months ago • 3 comments

Reference Issues/PRs

Contributes to #2497. Reference PRs #2518 and #2534.

What does this implement/fix? Explain your changes.

The given issue improvises the test coverage of AEAttentionBiGRUNetwork class.

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

No.

PR checklist

For all contributions
  • [X] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • [X] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • [ ] I've added the estimator/function to the online API documentation.
  • [ ] (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • [ ] (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

lucifer4073 avatar Feb 16 '25 22:02 lucifer4073

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#379E11}{\textsf{networks}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run mypy typecheck tests
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [ ] Disable numba cache loading
  • [ ] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Feb 16 '25 22:02 aeon-actions-bot[bot]

Refer issue #2560

lucifer4073 avatar Feb 21 '25 00:02 lucifer4073

@lucifer4073 after getting #2771 merged, you can update to main here, make sure temporal latent space is tested properly, take care of @baraline 's comments and then we can merge this one

hadifawaz1999 avatar May 02 '25 00:05 hadifawaz1999

Hi @baraline,

I have made the required changes. Have a look at it and let me know if anything else is required. Thanks

lucifer4073 avatar May 13 '25 18:05 lucifer4073