aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] n_jobs parameter usage improved

Open lucifer4073 opened this issue 10 months ago • 5 comments

Reference Issues/PRs

Contributes to #1886.

What does this implement/fix? Explain your changes.

Improves handling of n_jobs ; standarizes n_job validation. Documentation of init class parameters improved.

Does your contribution introduce a new dependency? If yes, which one?

No new dependencies. Uses existing check_n_jobs() utility from aeon.

Any other comments?

No

PR checklist

For all contributions
  • [X] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • [x] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • [ ] I've added the estimator/function to the online API documentation.
  • [ ] (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • [ ] (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

lucifer4073 avatar Jan 25 '25 09:01 lucifer4073

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run mypy typecheck tests
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [ ] Disable numba cache loading
  • [ ] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Jan 25 '25 09:01 aeon-actions-bot[bot]

@lucifer4073 Are you still working on this ? If so do you need any additional inputs?

baraline avatar Mar 01 '25 21:03 baraline

Hi @baraline,

Sorry for the delay. Got a little busy lately. I will make the changes within this week.

lucifer4073 avatar Mar 08 '25 05:03 lucifer4073

Is this still active @lucifer4073? Same with other PRs.

MatthewMiddlehurst avatar Apr 03 '25 11:04 MatthewMiddlehurst

Is this still active @lucifer4073? Same with other PRs.

I've been a bit busy lately. I will resolve all the PRs in the forecoming week.

lucifer4073 avatar Apr 03 '25 16:04 lucifer4073

Closing this as I don't think it is the direction we want to take this issue.

MatthewMiddlehurst avatar Jun 20 '25 21:06 MatthewMiddlehurst