aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] Coverage for the networks module

Open TonyBagnall opened this issue 10 months ago • 11 comments

Describe the feature or idea you want to propose

networks has a lot of parameters that are not covered in testing, it would be good if they were esp the ae ones @aadya940

Describe your proposed solution

add tests for network parameters

Describe alternatives you've considered, if relevant

No response

Additional context

No response

TonyBagnall avatar Jan 14 '25 09:01 TonyBagnall

Hello, I would like to contribute by adding tests for the network parameters. I found three test files related to ae in the networks module. Are these the parameters that require additional coverage, or are there other specific areas I should focus on? Any further details or guidance would be appreciated.

Nikitas100 avatar Jan 15 '25 11:01 Nikitas100

While this does not cover every single case and item we want tested, an east place to start is our test coverage https://app.codecov.io/gh/aeon-toolkit/aeon

MatthewMiddlehurst avatar Jan 15 '25 15:01 MatthewMiddlehurst

Hi @MatthewMiddlehurst ,

I noticed that the tests don't fully cover 10-11 files in the networks module. Would you prefer I start with specific files or parameters, or should I gradually work on covering all uncovered areas?

Thanks!

Nikitas100 avatar Jan 16 '25 16:01 Nikitas100

@Nikitas100 you can start with any file, typically divide the tasks to 1 network per pull request. :)

aadya940 avatar Jan 16 '25 16:01 aadya940

Hi @Nikitas100,

There seems to be a decent number of files which need a higher test coverage. It might be a good idea to collaborate on addressing this issue together.

lucifer4073 avatar Jan 25 '25 20:01 lucifer4073

Hi @Nikitas100 ,

If you are currently not working on this issue, I will be proceeding with the rest of the files.

lucifer4073 avatar Feb 13 '25 06:02 lucifer4073

@lucifer4073 I would like to collaborate together on addressing this issue.

kavya-r30 avatar Feb 20 '25 12:02 kavya-r30

Duplicated with #1233 ?

Cyril-Meyer avatar Feb 21 '25 15:02 Cyril-Meyer

Good catch, I have closed that one as this seems more recently active. @hadifawaz1999 is it fine to work on the clustering ones now?

MatthewMiddlehurst avatar Feb 24 '25 16:02 MatthewMiddlehurst

@MatthewMiddlehurst this morning I reviewed all the PRs for the test coverage stuff and asked for some changes, let me know what you think because other than my requests it's all good, i prefer having one test file for each network as its becoming less ans less common parameters, so once we have covered everything we can remove the common one that does a lot of if and else

hadifawaz1999 avatar Feb 24 '25 16:02 hadifawaz1999

Is this complete? Can still open PRs at least.

MatthewMiddlehurst avatar Mar 23 '25 18:03 MatthewMiddlehurst