aeon
aeon copied to clipboard
[BUG] Coverage and bug fixes for utils
got a bit bigger than I expected, so will put up as draft and note changes
Fixes #2135: changes parameter name Fixes #2134; requires weights passed as ndarray Removes unused broken weighting functions Adds tests for show_versions Adds tests for sklearn functions Makes files private with init imports: this is our general package wide policy (I think) and should be adopted where possible imo. Sub directories for utils can be changed in time
Thank you for contributing to aeon
I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon Slack channel if you have any.
PR CI actions
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
- [ ] Run
pre-commitchecks for all files - [ ] Run
mypytypecheck tests - [ ] Run all
pytesttests and configurations - [ ] Run all notebook example tests
- [ ] Run numba-disabled
codecovtests - [ ] Stop automatic
pre-commitfixes (always disabled for drafts) - [ ] Disable numba cache loading
- [ ] Push an empty commit to re-run CI checks
Changes look good, but I would just like some words about the change of approach for the import of the utils module. Do we now want to have most files as private and imported direclty from utils instead of their respective files ? (E.g utils.numba... for the numba utils etc...).
Changes look good, but I would just like some words about the change of approach for the import of the utils module. Do we now want to have most files as private and imported direclty from utils instead of their respective files ? (E.g utils.numba... for the numba utils etc...).
I think our package wide policy is to have imports via directory init, and this is just imposing that structure. e.g. I change it when I am doing related work in a directory, and hopefully over time this will be adopted, and its better to do it now before version 1.0 to avoid deprecation :)