aeon
aeon copied to clipboard
[ENH] Add test that the estimator "algorithm_type" is valid
Describe the feature or idea you want to propose
for collection estimators we use the _tags = {"algorithm_type": "distance"} as a taxonomy of algorithms. However we dont test they are valid, as identified in #1935
Describe your proposed solution
add a test the type is one of a valid list, probably defined in the base class?
Describe alternatives you've considered, if relevant
No response
Additional context
No response
@TonyBagnall @MatthewMiddlehurst Just creating a list of distances (like dtw, euclidean etc) in the base class and checking them to be valid in subclasses would solve the issue?
It would be a test checking that the value of algorithm_type is valid i.e. distance, interval, shapelet etc.
It would be a test checking that the value of
algorithm_typeis valid i.e.distance,interval,shapeletetc.
Raise an error if algorithm_tag isn't present? Cause some of them don't.
@aeon-actions-bot assign @aryanpola
I wouldn't raise an error for now
Above is outdated, all estimators should have the tag now. It may have a None value for now, however.