aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] Add test that the estimator "algorithm_type" is valid

Open TonyBagnall opened this issue 1 year ago • 5 comments

Describe the feature or idea you want to propose

for collection estimators we use the _tags = {"algorithm_type": "distance"} as a taxonomy of algorithms. However we dont test they are valid, as identified in #1935

Describe your proposed solution

add a test the type is one of a valid list, probably defined in the base class?

Describe alternatives you've considered, if relevant

No response

Additional context

No response

TonyBagnall avatar Aug 12 '24 12:08 TonyBagnall

@TonyBagnall @MatthewMiddlehurst Just creating a list of distances (like dtw, euclidean etc) in the base class and checking them to be valid in subclasses would solve the issue?

aryanpola avatar Sep 08 '24 07:09 aryanpola

It would be a test checking that the value of algorithm_type is valid i.e. distance, interval, shapelet etc.

MatthewMiddlehurst avatar Sep 16 '24 11:09 MatthewMiddlehurst

It would be a test checking that the value of algorithm_type is valid i.e. distance, interval, shapelet etc.

Raise an error if algorithm_tag isn't present? Cause some of them don't.

aryanpola avatar Sep 16 '24 13:09 aryanpola

@aeon-actions-bot assign @aryanpola

aryanpola avatar Sep 18 '24 06:09 aryanpola

I wouldn't raise an error for now

MatthewMiddlehurst avatar Sep 21 '24 10:09 MatthewMiddlehurst

Above is outdated, all estimators should have the tag now. It may have a None value for now, however.

MatthewMiddlehurst avatar Oct 28 '24 12:10 MatthewMiddlehurst