aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[MNT, DOC] Accelerating deep testing

Open hadifawaz1999 opened this issue 1 year ago • 1 comments

Fix #1761

  • Changes test params of deep classifiers/regressors/clusterers so that testing is faster
  • In deep specific tests, use the test parameters, as they were not used before, to accelerate testing
  • Fix random state deep clustering test, it was looping infinitely before because there was a bug, it was considering the encoder/decoder as layers before, not its fixed and ensures encoders and decoders are testing separately
  • Add possibility to use dummy clusterer in deep clustering, for the clustering in latent space, use it as test parameter to accelerate testing especially in no numba label. Another reason for this addition is that with test parameters of AE based clusterers in deep learning, if not trained long enough, kmeans may not converge and CI will fail with "ValueError: Unable to find a valid cluster configuration with parameters specified (empty clusters kept forming). Try lowering your n_clusters or raising n_init." so it will be a pain to find the best seed, so replacing with dummy clusterer is best option
  • Fix Encoder Network issue with Lambda layer, using now internal attention layer, as the original authors implemented the network before keras introduced Attention layers. The math isnt 100% the same but the idea of attention is the same
  • Doc issue with AEResNet

hadifawaz1999 avatar Aug 04 '24 12:08 hadifawaz1999

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#F3B9F8}{\textsf{documentation}}$, $\color{#EC843A}{\textsf{maintenance}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$, $\color{#379E11}{\textsf{networks}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [ ] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Aug 04 '24 12:08 aeon-actions-bot[bot]

hi @hadifawaz1999 this is very conflicted, it might be better to start again and do it in multiple PRs?

TonyBagnall avatar Feb 03 '25 17:02 TonyBagnall

hi @hadifawaz1999 this is very conflicted, it might be better to start again and do it in multiple PRs?

if am not mistaken, i dropped this and did every bullet point in a separate pr, will check what's left and close this one

hadifawaz1999 avatar Feb 03 '25 17:02 hadifawaz1999