aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[MNT] Remove `keras` bound

Open MatthewMiddlehurst opened this issue 1 year ago • 2 comments

Reference Issues/PRs

fixes #1724

What does this implement/fix? Explain your changes.

Removes the version bound on keras (if CI passes).

MatthewMiddlehurst avatar Jul 17 '24 11:07 MatthewMiddlehurst

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [ ] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Jul 17 '24 11:07 aeon-actions-bot[bot]

so good news keras fixed the loading issue and they are waiting for it to be released in keras 3.4.2 https://github.com/keras-team/keras/issues/19976 first issue that mentioned it: https://github.com/keras-team/keras/issues/19921 first pr that tried to fix it: https://github.com/keras-team/keras/pull/19924 second pr that tried to fix it: https://github.com/keras-team/keras/pull/19927 and now the new release is pr is still open once its in main we can re-run your pr on keras bound

hadifawaz1999 avatar Jul 18 '24 11:07 hadifawaz1999

can we try this now @MatthewMiddlehurst ?

hadifawaz1999 avatar Sep 04 '24 12:09 hadifawaz1999

feel free to make any changes you want

MatthewMiddlehurst avatar Sep 04 '24 14:09 MatthewMiddlehurst

keras 3.5 was released so its all good

hadifawaz1999 avatar Sep 05 '24 11:09 hadifawaz1999