aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] MrSEQLClassifier wrapper

Open MatthewMiddlehurst opened this issue 1 year ago • 8 comments

What does this implement/fix? Explain your changes.

Start of a mrseql wrapper. Unfortunately, I can't quite find how to parameterise it currently after installing on Windows 🙂.

If anyone can find it in the source that that would be helpful: https://github.com/lnthach/Mr-SEQL

Does your contribution introduce a new dependency? If yes, which one?

mrseql

MatthewMiddlehurst avatar Jul 03 '24 15:07 MatthewMiddlehurst

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [x] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)
  • [x] Push an empty commit to re-run CI checks

aeon-actions-bot[bot] avatar Jul 03 '24 15:07 aeon-actions-bot[bot]

@lnthach Hi Thach, I am having a bit of trouble figuring out what parameters your MrSEQL pypi package has and what defaults I should set for them. Would you be able to comment and help me with this?

MatthewMiddlehurst avatar Jul 29 '24 22:07 MatthewMiddlehurst

@MatthewMiddlehurst Hi Matthew, I just had a quick look. I think your job would be easier if I make some changes on my side. At this stage I believe it wouldn't pass the checks anyway. I will get back to you later once it's updated (asap).

lnthach avatar Jul 31 '24 13:07 lnthach

@MatthewMiddlehurst Hi Matthew, I just updated mrseql (v0.0.4) on pypi so I hope it would make things easier for you. I also remove sktime dependency but use fftw3 library instead (same dependencies as mrsqm).

Currently there are three parameters for MrSEQLClassifier and the default values are as follows: MrSEQLClassifier(seql_mode='fs', symrep=('sax'), custom_config=None)

Please let me know if it works for you.

lnthach avatar Aug 02 '24 13:08 lnthach

@lnthach Thanks for this. Raised the version found but it seems to be failing to install on our Linux runner (https://github.com/aeon-toolkit/aeon/actions/runs/10247769782/job/28347641403?pr=1756). mrsqm installs fine by the look of things

MatthewMiddlehurst avatar Aug 05 '24 11:08 MatthewMiddlehurst

@MatthewMiddlehurst This one is strange. Both uses the same sfa implementation so both depends on fftw3. One possible reason is that mrsqm installed from built distribution hence the installation somehow bypassed this dependency (not sure if this is possible to be honest). I have some issues with generating the built distribution for mrseql so I uploaded only the source distribution. Do you think this could be the reason ?

lnthach avatar Aug 05 '24 17:08 lnthach

@lnthach I think thats likely, not really sure how to resolve it through as I dont have much experience wrapping C, let alone distributing it 🙂. If the parameters used are the same I can restrict it to 0.0.2 for now?

MatthewMiddlehurst avatar Aug 06 '24 11:08 MatthewMiddlehurst

@MatthewMiddlehurst I just uploaded the built distribution for v0.0.4. Could please you check if it still fails ?

lnthach avatar Aug 06 '24 15:08 lnthach

Seems to all be running fine @lnthach

MatthewMiddlehurst avatar Aug 14 '24 11:08 MatthewMiddlehurst