aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] Tidy up unequal length collection transformers

Open TonyBagnall opened this issue 1 year ago • 4 comments

fixes #1156

We have three transformers to make unequal length series equal length. One pads, one truncates and one stretches. This PR renames them Truncator, Padder and Resizer, makes the files private and reworks the associated notebook, which could ultimately be merged with the one on unequal length series.

TonyBagnall avatar Jun 27 '24 22:06 TonyBagnall

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • [ ] Run pre-commit checks for all files
  • [ ] Run all pytest tests and configurations
  • [ ] Run all notebook example tests
  • [ ] Run numba-disabled codecov tests
  • [ ] Stop automatic pre-commit fixes (always disabled for drafts)

aeon-actions-bot[bot] avatar Jun 27 '24 22:06 aeon-actions-bot[bot]

Looks good, but needs deprecation. Pretty sure everything can stay as it is now just add the old classes and __init__ with a warning

I thought that collections was experimental? Conflicted with deprecation in any case, might just leave this until after the next release

TonyBagnall avatar Jul 19 '24 08:07 TonyBagnall

Series is but collection is not. Have it listed in the README

MatthewMiddlehurst avatar Jul 22 '24 14:07 MatthewMiddlehurst