aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[MNT] check_estimator

Open MatthewMiddlehurst opened this issue 9 months ago • 1 comments

Reference Issues/PRs

Relies on #1476

What does this implement/fix? Explain your changes.

todo

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

PR checklist

For all contributions
  • [ ] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • [ ] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • [ ] I've added the estimator to the online API documentation.
  • [ ] (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • [ ] (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

MatthewMiddlehurst avatar Apr 27 '24 00:04 MatthewMiddlehurst

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#2C2F20}{\textsf{testing}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

aeon-actions-bot[bot] avatar Apr 27 '24 00:04 aeon-actions-bot[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Actually, with forecasting more officially deprecated now, I can probably remove the legacy check function. Can keep for now if people disagree.

MatthewMiddlehurst avatar Jul 02 '24 22:07 MatthewMiddlehurst

Actually, with forecasting more officially deprecated now, I can probably remove the legacy check function. Can keep for now if people disagree.

I vote remove it

TonyBagnall avatar Jul 03 '24 12:07 TonyBagnall