aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[DEP] Deprecate the ACF and PACF BaseTransformer wrappers

Open TonyBagnall opened this issue 10 months ago • 1 comments

as part of #1446, replacing these thin wrappers with BaseSeriesTransformer wrappers, and we also provide our own cut down ACF function (with PACF to follow) through deprecation

Two things to note: neither of these wrappers handled soft dependencies in the standard way, and I have converted to internal numpy, since statsmodels simply converts to numpy itself internally and makes no use of an index.

p.s. changed two typos in other deprecation messages I came across along the way. Changed the names until deprecation because it confuses the CI having two classes with the same name

TonyBagnall avatar Apr 24 '24 22:04 TonyBagnall

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#7E0206}{\textsf{regression}}$, $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

aeon-actions-bot[bot] avatar Apr 24 '24 22:04 aeon-actions-bot[bot]