aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[MNT] Tensorflow Python 12

Open MatthewMiddlehurst opened this issue 10 months ago • 8 comments

Manually adding the InstanceNormalization layer in aeon given the deprecation of the tensorflow_addons package in May 2024. Fix #1144

MatthewMiddlehurst avatar Apr 14 '24 10:04 MatthewMiddlehurst

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

aeon-actions-bot[bot] avatar Apr 14 '24 10:04 aeon-actions-bot[bot]

Just need to copy paste the InstanceNormalization code https://github.com/tensorflow/addons/blob/v0.20.0/tensorflow_addons/layers/normalizations.py#L296-L338 from tensorflow-addons and add it manually for EncoderNetwork and remove tensorflow-addons from dependencies if you want i can push it on this branch

hadifawaz1999 avatar Apr 14 '24 11:04 hadifawaz1999

@hadifawaz1999 feel free to do so

MatthewMiddlehurst avatar Apr 16 '24 14:04 MatthewMiddlehurst

Also there is a conflict

MatthewMiddlehurst avatar Apr 29 '24 16:04 MatthewMiddlehurst

Also there is a conflict

resolving conflict is adding back tensorflow addons, not sure why

hadifawaz1999 avatar Apr 29 '24 16:04 hadifawaz1999

just remove it again in the merge, cant get around merging with main.

MatthewMiddlehurst avatar Apr 29 '24 16:04 MatthewMiddlehurst

just remove it again in the merge, cant get around merging with main.

nothing is working :) tried even to change only the addon, but still conflict exist as long as the file is changed...

hadifawaz1999 avatar Apr 29 '24 17:04 hadifawaz1999

you have to pull the main branch. done so above.

MatthewMiddlehurst avatar Apr 29 '24 18:04 MatthewMiddlehurst

@hadifawaz1999 try pulling #1585 into this. Maybe it's Intel MacOS.

MatthewMiddlehurst avatar Jun 04 '24 16:06 MatthewMiddlehurst

@hadifawaz1999 try pulling #1585 into this. Maybe it's Intel MacOS.

maybe should wait till the #1585 passes test ? and i think it is, because it doesnt make sense, the test where its stucking are not even deep related, and each time i run the job it gets stuck on a new test, first i saw transformer test, then forecasting test

hadifawaz1999 avatar Jun 04 '24 16:06 hadifawaz1999

Bit confused by tags, but looks good to me. Probably change the title of the PR though

TonyBagnall avatar Jul 03 '24 18:07 TonyBagnall

finishing this off and then resuming later on with #1760

hadifawaz1999 avatar Jul 04 '24 09:07 hadifawaz1999