aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] Update Catch22 transformer

Open MatthewMiddlehurst opened this issue 10 months ago • 2 comments

Describe the feature or idea you want to propose

Since its implementation, the numba version of Catch22 (code here) has become slightly out of date compared to the original implementation.

The features which now differ should be updated, and parity with the original output should be verified

Describe your proposed solution

Look at the authors implementation (C code), and update our version of the features in numba to match.

The transformer has a parameter to use this package, so the results can be compared to verify they are the same (or similar).

Describe alternatives you've considered, if relevant

No response

Additional context

No response

MatthewMiddlehurst avatar Apr 08 '24 09:04 MatthewMiddlehurst

this can be a good first issue @MatthewMiddlehurst you agree ?

hadifawaz1999 avatar Apr 27 '24 21:04 hadifawaz1999

It requires an understanding of the algorithm and involves comparing to and probably running C code, so probably not.

MatthewMiddlehurst avatar Apr 27 '24 21:04 MatthewMiddlehurst

The alternative would be to switch to pycatch22. https://github.com/aeon-toolkit/aeon/pull/1235

it would be good to profile the two

TonyBagnall avatar Jun 18 '24 13:06 TonyBagnall

I still don't really trust it due to previous issues with installation and Windows. If it is proven to be stable then can consider it.

MatthewMiddlehurst avatar Jun 18 '24 22:06 MatthewMiddlehurst