aeon icon indicating copy to clipboard operation
aeon copied to clipboard

Published 20 hours ago • verified publisher icon aeon-toolkit

[ENH] Add Swale Scoring Model

Open aadya940 opened this issue 10 months ago • 8 comments

Related to: #425

Implemented as per this paper, Section 5.

Couldn't verify the correctness due to a lack of alternate implementations. I shall continue to work on this once we track down an alternate implementation?

aadya940 avatar Apr 03 '24 08:04 aadya940

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#5209C9}{\textsf{distances}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

aeon-actions-bot[bot] avatar Apr 03 '24 08:04 aeon-actions-bot[bot]

Is this ready to go? There seems to be a conflict currently. People are less likely to look at drafts 🙂.

MatthewMiddlehurst avatar Apr 18 '24 12:04 MatthewMiddlehurst

@MatthewMiddlehurst From my side this looks ready to go. However, I'm not 100% confident about the logic used. We should check this up against an alternate implementation (which I couldn't track down) if something looks wrong to you. :-)

aadya940 avatar Apr 19 '24 08:04 aadya940

thanks for this, I missed it. I will look for an implementation, probably one in matlab. There is a conflict with test_expected_results though

TonyBagnall avatar Apr 22 '24 14:04 TonyBagnall

so the implementation is true to the definition in the paper, but I dont think defining this recursively is a good idea. It would be better if it followed the model used by LCSS. @chrisholder and I will take a look and get back to you

TonyBagnall avatar Apr 23 '24 10:04 TonyBagnall

There seems to be a conflict which has to be resolved, but @chrisholder has approved so this should be quick to merge after given him and @TonyBagnall have no issues with it.

MatthewMiddlehurst avatar May 07 '24 14:05 MatthewMiddlehurst

@aadya940 Not quite sure where we left off with this. Seems like it was close?

MatthewMiddlehurst avatar Sep 21 '24 13:09 MatthewMiddlehurst

@MatthewMiddlehurst Yes, I guess during this PR some testing suite in distances was revamped. Hence, the testing part is left.

aadya940 avatar Sep 21 '24 19:09 aadya940