aeon
aeon copied to clipboard
[DOC] non visible rows in darkmode documentation website
Describe the issue linked to the documentation
Not a big problem of course but in dark mode in my browser, some tables rows in the online documentation are not visible (example screenshot shows Time Series Regression example page)
Suggest a potential alternative/fix
Maybe automatically adapt to dark mode
Thanks for opening an issue. I have also noticed this, but I have no idea how to fix it to be honest!
I think it would require some custom CSS for how furo
interacts with nbsphinx
for pandas.Dataframe
output. I was thinking of opening a discussion on the furo
repo to see if anyone can help, but have not gotten around to doing so yet.
Hey @MatthewMiddlehurst
I have been able to re-produce and even fix the issue locally. All I had to do was edit in custom.css
and add a new style property.
The tables mentioned in this issue are actually Pandas Dataframes, so after inspecting I found out that those have a default class of dataframe
in the generated HTML.
So I have to add a new property in custom.css
with dataframe
class and that would fix it.
Can I work on this one?
Just checked the latest docs, and this issue seems to be already fixed in that it just has to be moved to stable.
This issue should be closed I guess.
I still see the issue in latest:
@inclinedadarsh, could you open a PR with your proposed changes to custom.css
?
All on Linux:
- Vivaldi 6.9.3447.54
- Chromium 129.0.6550.0
- Firefox 134.0
Still an issue for me also on latest
. Windows/Firefox. Would be happy to take a look if you have a fix, IMO best would just be white text when the background is black but maybe thats a pain to look at 🙂
Sure, I'll raise a PR on this
@aeon-actions-bot assign @inclinedadarsh
@SebastianSchmidl @MatthewMiddlehurst I have raised a PR at #2508 fixing this issue.
Please have a look and let me know if any othe changes are required.
Thank you!