aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH] refactor write_to_tsfile to use `n_timepoints` instead of `series_length`

Open TonyBagnall opened this issue 1 year ago • 2 comments

Describe the feature or idea you want to propose

some time ago we agreed on calling the shape of collections of time series (n_cases, n_channels, n_timepoints). Some classes and functions still use series_length instead of n_timepoints , which is fine, but we would like to standardise. For example, the function _write_data_to_tsfile in datasets._datawriters internally used series_length

Describe your proposed solution

refactor this function so that it uses a local variable n_timepoints instead of series_length

Describe alternatives you've considered, if relevant

No response

Additional context

No response

TonyBagnall avatar Feb 07 '24 21:02 TonyBagnall

Hi, I would like to take up this issue.

Neelaksh-Singh avatar Feb 25 '24 05:02 Neelaksh-Singh

Hi, is the issue still open? the issue seems fixed.

harshithasudhakar avatar Mar 14 '24 14:03 harshithasudhakar

yes its fixed

TonyBagnall avatar Jun 27 '24 20:06 TonyBagnall