etcd-operator icon indicating copy to clipboard operation
etcd-operator copied to clipboard

WIP: Refactoring certs and volumes for sts

Open sergeimonakhov opened this issue 1 year ago • 2 comments

This pull request introduces code changes related to managing volumes for the STS object. Key modifications include the addition of structures to store certificate information and the definition of paths to certificate files. Additionally, changes have been made to the creation and mounting of the data volume for the ETCD container. These alterations aim to enhance certificate handling and data management within the controller's context.

sergeimonakhov avatar Apr 12 '24 19:04 sergeimonakhov

@sergeimonakhov Please run make lint-fix to resolve pre-commit errors and fix tests

sircthulhu avatar Apr 13 '24 06:04 sircthulhu

@sircthulhu I added even more refactoring and fixed the code to make the tests run. Overall, the base code was very poor; we need to be more stringent in our code reviews because it will become impossible to maintain if we keep accepting sloppy work.

sergeimonakhov avatar Apr 13 '24 16:04 sergeimonakhov

closed in favor https://github.com/aenix-io/etcd-operator/issues/224

kvaps avatar May 28 '24 14:05 kvaps