Make additional validation for configmap of cozystack
Hi!
Right now it is easy to make a typo when preparing the cozy-stack configmap:
apiVersion: v1
kind: ConfigMap
metadata:
name: cozystack
namespace: cozy-system
data:
bundle-name: "paas-full"
ipv4-pod-cidr: "100.64.0.0/16"
ipv4-pod-gateway: "10.64.0.1"
ipv4-svc-cidr: "10.65.0.0/16"
ipv4-join-cidr: "100.66.0.0/16"
I think it could be beneficial to install before applying some kind of webhook which will check the parameters and write meaningful errors (like "bundle name is not supported") or even switch from CM to our own CRD with a proper schema.
@gecube
I am working on operator for cozystack.
It seems we need to fail installer binary on start in case of any errors in configmap, thanks added to backlog
Hi, @gecube. I'm Dosu, and I'm helping the cozystack team manage their backlog and am marking this issue as stale.
Issue Summary:
- You suggested adding validation for the cozy-stack ConfigMap to prevent typos and misconfigurations.
- A webhook or replacing the ConfigMap with a CRD was proposed for schema enforcement.
- Contributor mrkhachaturov is working on an operator for cozy-stack, which you and others supported.
- Maintainer kvaps agreed on failing the installer binary on startup if ConfigMap errors exist and added this to the backlog.
- Progress is being made toward improving configuration validation and error handling.
Next Steps:
- Please confirm if this issue is still relevant with the latest version of cozystack; if so, you can keep the discussion open by commenting here.
- Otherwise, I will automatically close this issue in 7 days.
Thanks for your understanding and contribution!