cozystack icon indicating copy to clipboard operation
cozystack copied to clipboard

PoC: Move dashboard-resourcemap to controller

Open kvaps opened this issue 2 months ago • 2 comments

Signed-off-by: Andrei Kvapil [email protected]

What this PR does

Release note

[]

kvaps avatar Nov 04 '25 19:11 kvaps

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch rbac-refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 04 '25 19:11 coderabbitai[bot]

Summary of Changes

Hello @kvaps, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the management of dashboard-related RBAC resources within the Cozystack ecosystem. It transitions from a decentralized approach, where each application's Helm chart defined its own dashboard resource mappings, to a centralized controller-based model. The new DashboardResourcesReconciler now observes HelmRelease and CozystackResourceDefinition objects to dynamically create, update, and clean up necessary Role and RoleBinding resources, ensuring consistent and automated RBAC for dashboard access across applications.

Highlights

  • New Controller for Dashboard Resources: Introduced a new DashboardResourcesReconciler to centralize the management of Kubernetes Role-Based Access Control (RBAC) resources for dashboard access. This controller dynamically creates and updates Role and RoleBinding objects based on HelmRelease and CozystackResourceDefinition objects.
  • Dynamic RBAC Provisioning: The new controller automatically generates RBAC rules for secrets, services, ingresses, and workload monitors, templating resource names based on the associated HelmRelease and CozystackResourceDefinition specifications. It also handles the generation of RBAC subjects for tenant namespaces.
  • Removal of Static Helm Chart RBAC: Eliminated numerous dashboard-resourcemap.yaml files from various application Helm charts (e.g., bucket, clickhouse, kafka, postgres, redis, virtual-machine, etc.). This removes redundant and static RBAC definitions, streamlining chart maintenance and ensuring consistent RBAC policy application.
  • Improved Code Structure: The change moves the logic for dashboard resource mapping from distributed Helm templates into a single, dedicated Go controller, enhancing maintainability and testability of the RBAC provisioning logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 04 '25 19:11 gemini-code-assist[bot]