aemkei.github.io icon indicating copy to clipboard operation
aemkei.github.io copied to clipboard

This one comes with a few caveats...

Open rlauck opened this issue 12 years ago • 3 comments

Changes:

  1. Ditched the id and with block - values cached in global scope
  2. Rewrite the table contents every blur
  3. Fixed: Plain strings in cells were throwing an exception

Cons:

  1. Because the table is rewritten onblur, tabbing no longer works and you have to click twice to edit another cell.
  2. Bad cell values or formulas will cause the table to fail to render until you manually clear the value from localStorage

rlauck avatar Nov 29 '13 02:11 rlauck

Nice rewrite and down to 281! Just had t call localStorage.clear() to make it work.

But in my opinion, it is too hard to use, because you can't just click another cell to edit.

https://rawgithub.com/rlauck/aemkei.github.io/c5b52604e71b0a8a96a8de823f712b332c884cb0/sheet/index.html

@p01 and @subzey: What do you think?

aemkei avatar Nov 29 '13 09:11 aemkei

Well done getting this to 281.

@aemkei: I tried the same approach and found that rewriting the table onblur made the spreadsheet way TOO hard to use. Thus I did not even commit, push, pull-request

p01 avatar Nov 29 '13 11:11 p01

I agree that this makes it hard to use, probably not a good idea to merge this in its current state.

I had an earlier version that was around 287 so I'll revert this pull request back to that when I have time later today. Thanks for taking a look guys

rlauck avatar Nov 29 '13 14:11 rlauck