Alec Embke comments

Results 90 comments of


                                            Alec Embke

cannot used in tokio?

Hi @Praying. The codec interface should work with Tokio, but from this code it's not obvious what the issue is. I won't be able to reproduce this due to the...

[Feature] Interfaces design flaw

Hi @sitano, thanks for bringing this up. I hadn't originally intended for folks to implement that trait, but I can see why it would be useful in cases like this....

[Bug] Calling `RedisPool.active_connections()` may block forever

Hi @nakedible-p, good callout. I'll change that in the next update so it can preempt reconnections.

[Bug] Calling `RedisPool.active_connections()` may block forever

Thanks @nakedible-p, this should be fixed in 9.3.0

[Bug] Vec<u8> is recognised as Array rather than Bytes

Hi @dracarys18, Unfortunately I'm not sure how to do this on stable rust at the moment without [specialization](https://github.com/rust-lang/rust/issues/31844), but feel free to submit a PR if you can make it...

[Bug] Vec<u8> is recognised as Array rather than Bytes

Sounds good. In [9.4.0](https://github.com/aembke/fred.rs/pull/308) there a new FF `specialize-into-bytes` that will disable `From for RedisValue` and enable `TryFrom for RedisValue` such that it uses `RedisValue::Bytes`.

[Bug] Vec<u8> is recognised as Array rather than Bytes

Added in [9.4.0](https://github.com/aembke/fred.rs/releases/tag/v9.4.0)

implement 'SETNX' command

I'll try to get a new release out early next week

implement 'SETNX' command

Thanks @AverageADF, this will be cherry-picked into 9.3.0 - https://github.com/aembke/fred.rs/pull/298

[Bug] `RedisValue::Bytes` came back as `RedisValue::String` after roundtrip to Redis

Hi @feelingsonice, first off my apologies on the delay getting back to you here. A bit of background quick - this is due to the client doing a `str::from_utf8` call...