Ahmed Elsabbahy
Ahmed Elsabbahy
Closed by #697
I created v4-bug to track bugs on the v4 release. Feel free to open more bugs on this branch as you encounter them. Is everything working well for you now...
Can you explain at a high level the difference between this PR and #607? I'm going to cross reference this PR with the open issue to hopefully get some reviews...
@petemounce would love your review on this since you spent a lot of time thinking about this problem. I'm open to merging whatever the community agrees on.
I've tagged this issue in #607 in the hopes that it garners the attention of those watching that issue. To be honest with you, not being a Prometheus expert myself,...
Thanks for the feedback @t2d ! Tagging a few of the active participants from the previous chat to get a better gauge on consensus on this PR. Glad to see...
Ok, going to take the inverse approach. Last call to provide feedback on this before it goes out. If I don't get an objection to this PR within a week,...
@mhuysamen and @t2d do you agree with the above? I know @petemounce time is limited, but if #607 is the way to go, it's a minor merge conflict away from...
#607 has been merged, so I am closing this for now. Next goss release will have #607 in it. Follow up PRs welcome, glad to see this finally get completed...
Hello Keithy, Thanks for the suggestion, I believe this feature already exists in Goss. Please let me know if I misunderstood. https://github.com/aelsabbahy/goss/blob/master/integration-tests/goss/goss-shared.yaml#L170-L175