voyager icon indicating copy to clipboard operation
voyager copied to clipboard

Jump to top in Communities

Open kerosyn opened this issue 1 year ago • 1 comments

Currently when viewing favourites/subscribed communities it does not appear possible to jump to the top of the Communities by pressing the Posts button on the bottom bar.

Expectation Pressing the Posts button should jump to the top of Communities, like it does for posts once viewing All/Home/Local.

Related to issue #92

Running: iOS 17 Developer Beta 2 Safari iPhone 13 Voyager 0.19.0

kerosyn avatar Jul 11 '23 05:07 kerosyn

I can replicate this issue on iOS, iPadOS and Windows 11 (Edge) on Voyager 0.19.0 installed as app.

Has issues: iPhone 11 Pro, iOS 16.5.1, Safari iPad Pro 2018, iPadOS 16.5.1, Safari Dell XPS 13, Windows 11, Edge

Daneish avatar Jul 11 '23 08:07 Daneish

Not sure if this is apolloparity but tapping pretty above the community name in the top bar on both the listing of posts or post detail and comments screens taking you to the top is pretty common on the apps that I am using. Dystopia and Narwhal both implement this.

Narwhal and Dystopia both seem to have a sweet spot above the community name.

It's very useful. I can record the behavior if that would be helpful.

robertafreese avatar Jul 11 '23 19:07 robertafreese

Not sure if this is apolloparity but tapping pretty above the community name in the top bar on both the listing of posts or post detail and comments screens taking you to the top is pretty common on the apps that I am using. Dystopia and Narwhal both implement this.

Apollo did have that, clicking right below the notch. What I mentioned I don’t even remember if it was in Apollo, but it to make it so pressing the Post button functions identically both when viewing posts and Communities since both are housed under the same “Posts” view.

It’s always handy to have a way to jump to the top.

kerosyn avatar Jul 12 '23 02:07 kerosyn

This should be resolved in 0.20.0!

aeharding avatar Jul 12 '23 02:07 aeharding

I don't know what I am doing wrong, but this is not working for me on Android or iOS. Tapping at the top of the screen has no effect. I could try to record a session if that would help.

robertafreese avatar Jul 13 '23 02:07 robertafreese

He meant that if you press the posts button it jumps to the top. Pressing the status bar at the top to jump to the top is unresolved (see #92 I think).

rsammelson avatar Jul 13 '23 03:07 rsammelson

Yep, tapping the status bar will never work for PWAs unless browsers implement an API.

aeharding avatar Jul 13 '23 03:07 aeharding

@aeharding I mentioned this in that other issue, but I still don't understand why it's not possible to do this but it is possible to open the community search when you click the feed status bar.

rsammelson avatar Jul 13 '23 03:07 rsammelson

The tab bar is just HTML in the page that we fully control. But the native OS status bar is fully controlled by the OS - it's an overlay of the HTML page itself - and it's impossible to intercept tap events to it.

aeharding avatar Jul 13 '23 03:07 aeharding

See #418, but my understanding of what others wanted (and what I would like) is just tapping on the title bar to scroll, not necessarily all the way up to the status bar.

rsammelson avatar Jul 13 '23 03:07 rsammelson

Ah ok, yes I will watch 418 then, thanks. I figured out subscribing and will test as it progresses.

robertafreese avatar Jul 13 '23 12:07 robertafreese