voyager icon indicating copy to clipboard operation
voyager copied to clipboard

Add support for blocking communities

Open mdecourcy opened this issue 2 years ago • 1 comments

mdecourcy avatar Jul 02 '23 22:07 mdecourcy

Let me know if I should be feature branching, so my PRs don't include already merged requests.

mdecourcy avatar Jul 02 '23 22:07 mdecourcy

Can you fix the type checking issues?

rsammelson avatar Jul 03 '23 18:07 rsammelson

Can you fix the type checking issues?

Done, also resolved merge conflict.

E: Didn't get them all, apparently. Unsure why my vscode isn't picking them up on my local.

mdecourcy avatar Jul 03 '23 18:07 mdecourcy

Might be worth adding a warning modal before applying the block.

mdecourcy avatar Jul 03 '23 20:07 mdecourcy

Hi! Thanks for the PR.

The main problem with this is there is no block list in settings to undo. So we cannot merge that until user settings is implemented. But that is a larger scope thing that needs to wait atm.

That's why this PR is not going to be merged yet.

aeharding avatar Jul 04 '23 03:07 aeharding

@aeharding

I can add that. Perhaps with an ion iOS list, similar to what is in the settings page?

As for the unblock buttons, red circle similar to the remove/log out of user flow?

Edit: reread your comment, if you believe this should wait no worries!

mdecourcy avatar Jul 04 '23 03:07 mdecourcy

BTW, I haven't forgotten about this! I will be working on some user configuration settings stuff shortly and then we can get this in.

aeharding avatar Jul 05 '23 03:07 aeharding

Did you mean to close this @mdecourcy?

aeharding avatar Jul 06 '23 06:07 aeharding

Apologies reopened in #294

mdecourcy avatar Jul 06 '23 07:07 mdecourcy