voyager icon indicating copy to clipboard operation
voyager copied to clipboard

Feat: Persist 'Share as Image' options

Open sharunkumar opened this issue 1 year ago • 5 comments

Resolves #1547

All the toggle buttons would be persisted

In the case where the user hits the upper limit for parent comments, the setting would remember it and set all future shares to have all parent comments visible

sharunkumar avatar Aug 11 '24 08:08 sharunkumar

@aeharding also, currently one of the toggles is labelled "Include Post Text", which seems to be misleading. In case of image posts, this actually toggles the image within the screenshot

Update: I've renamed it to "Include Post Content"

sharunkumar avatar Aug 11 '24 09:08 sharunkumar

Thanks for making this PR!

I tried to run locally, but the image isn't appearing (Firefox). It working in main but I haven't investigated further.

Screenshot 2024-08-12 at 10 55 48 PM

aeharding avatar Aug 13 '24 03:08 aeharding

I tried opening the built docker version on Firefox and it seems to be working: image

arch linux btw

Update: it even works as expected when running with pnpm dev:

image

sharunkumar avatar Aug 13 '24 07:08 sharunkumar

@sharunkumar Can you try share as image on the post, not a comment? That is where it fails for me.

aeharding avatar Sep 29 '24 17:09 aeharding

@sharunkumar Can you try share as image on the post, not a comment? That is where it fails for me.

I'll look into it in a bit

sharunkumar avatar Oct 03 '24 19:10 sharunkumar