voyager icon indicating copy to clipboard operation
voyager copied to clipboard

Select text button shows up when there's no text to select

Open aeharding opened this issue 2 years ago • 3 comments

@httpjamesm, can you take a look at this? Mainly for URL posts.

Other issues:

  1. Select text dialog scrolls up/down when trying to select text. We should disable gestures for the dialog I think
  2. Select text contents needs a bit of padding
  3. Select text should use a text area or something that behaves a bit better on desktop. Right now, it's just text in the HTML

aeharding avatar Jul 01 '23 18:07 aeharding

I've addressed the first two. I don't understand the need for the third. On desktop I'm able to select just fine

httpjamesm avatar Jul 01 '23 19:07 httpjamesm

Thanks!

When I tap once on desktop Firefox, the headers are also selected.

image

A text area would ensure you can only drag to select the text within the text area.

aeharding avatar Jul 01 '23 19:07 aeharding

Got it. I haven't tested it on Firefox.

httpjamesm avatar Jul 01 '23 19:07 httpjamesm

Should be resolved :)

aeharding avatar Oct 29 '23 01:10 aeharding