voyager icon indicating copy to clipboard operation
voyager copied to clipboard

Send backpresses to the image viewer only

Open Gloix opened this issue 1 year ago • 2 comments

Backpresses are not handled correctly:

  • Open app in posts section
  • Open a post with an image
  • Tap on the image to view full screen
  • Press back

Actual: UI below the image performs a back transition and then the image viewer is dismissed. Expected: Only image viewer is dismissed. Post should be still open.

Gloix avatar Jul 01 '23 02:07 Gloix

Hello! Thanks for the issue.

I suppose we could push a query param, ?imageViewer=1 or something to the url. That would allow android back button to work.

aeharding avatar Jul 01 '23 03:07 aeharding

This also seems to happen when replying to a post. You can open up the comment screen and use the back button. If you exit the comment screen, you will find yourself back one screen from where you were.

aperson avatar Jul 02 '23 20:07 aperson

I just tested on wefwef 0.12.0 and yeah, you get a prompt asking you if you want to discard your comment now (great!), but it doesn't go back to the thread, it goes back directly to the posts list.

As for images, it also goes back instead of simply closing the image.

I made a screen record of the issue.

https://github.com/aeharding/wefwef/assets/9488095/7784098d-90a4-4a46-8f28-a2d4140fa3ef

ToNIX- avatar Jul 04 '23 17:07 ToNIX-

I think #93 is the same thing but the example is for a different menu.

rsammelson avatar Jul 04 '23 18:07 rsammelson

Hijacking this issue related to closing the image viewer to say that a tap in the overlay around the image should close the preview too! Thanks in advance :)

Edit : TIL swiping down closes the picture. But still I think tapping the overlay and using the back button should also close it.

beeb avatar Jul 05 '23 20:07 beeb

I'm working on this now.

@beeb Please make a different issue for tap backdrop if it doesn't exist :)

aeharding avatar Jul 05 '23 23:07 aeharding

Thanks for fixing this. Love the app!

Gloix avatar Jul 08 '23 18:07 Gloix