boot-reload icon indicating copy to clipboard operation
boot-reload copied to clipboard

Evaluate using figwheel.client code

Open martinklepsch opened this issue 10 years ago • 4 comments

Pros:

  • community effort bundled in one project
  • dependency ordering + filtering of reloadable files would not need to be re-implemented

Cons:

  • potentially more complex to maintain (effort shared by more people though)
  • special cases for boot tooling might not be possible (e.g. displaying SASS compilation errors)
  • speed with which we could implement features/fixes might be reduced

Please discuss :smile:

martinklepsch avatar Oct 07 '15 20:10 martinklepsch

Would probably be possible for Figwheel to display any messages. Anyway as we continue to have our server, we can send errors from any boot task.

Deraen avatar Oct 07 '15 20:10 Deraen

Figwheel client doesn't currently support reloading the HTML file, should be easy to implement though.

Deraen avatar Oct 07 '15 20:10 Deraen

Alternatively maybe it would be an option to create something new that copies the dependency ordering etc but is flexible enough to be used as figwheel.client 2.0 as well as for boot-reload. edit: like some cljs-only library that gets websocket messages and reloads/displays stuff :)

martinklepsch avatar Oct 07 '15 20:10 martinklepsch

There is a plugin system of sorts in figwheel. You can pick up any messages you send from the server and act on them. This shouldn't be difficult.

Also worth thinking about repl eval. Only having one websocket and one client connection can be a big win.

bhauman avatar Oct 07 '15 23:10 bhauman