boot-cljs-repl icon indicating copy to clipboard operation
boot-cljs-repl copied to clipboard

outdated piggieback dependency?

Open OlafMerkert opened this issue 7 years ago • 3 comments

It seems to me that com.cemerick/piggieback has been superseded by cider/piggieback. At least cider itself seems to be of that opinion. Should the dependency be updated?

OlafMerkert avatar May 11 '18 09:05 OlafMerkert

See #61

arichiardi avatar May 23 '18 18:05 arichiardi

I would say things are still evolving but I see that these deps will need to be updated for it to work:

https://github.com/adzerk-oss/boot-cljs-repl/blob/master/src/adzerk/boot_cljs_repl.clj#L18-L21

Another nice thing to do would probably be to read the current deps coming from build.boot and take those in case. The deps in the snipped above should be the default but not the only ones we consider.

arichiardi avatar Jul 22 '18 19:07 arichiardi

It seems to me that com.cemerick/piggieback has been superseded by cider/piggieback. At least cider itself seems to be of that opinion. Should the dependency be updated?

Btw, despite of the namespace that's not something to do with CIDER. At the time when the project was handed over to me the nREPL org didn't still exist and this seem like a reasonable coordinate for the artefact. I would have chosen nrepl/piggieback if I were doing this today, but it is what it is.

bbatsov avatar Jul 23 '18 15:07 bbatsov