Adwait Godbole

Results 63 comments of Adwait Godbole

> Hi @adwait-godbole, replying via email as I'm not on my PC right now. Will have a closer look at the code tonight. UI looks good now but instead of...

> Not showing anything immediately doesn't look good to me. I didn't read super carefully but I wouldn't expect it to be slow to load all data? It's not that...

> Not showing anything immediately doesn't look good to me. I didn't read super carefully but I wouldn't expect it to be slow to load all data? It's not that...

@AgniveshChaubey hope you find some time today to review this. Thanks.

> I saw you have used FC in many components to define the type of Props. But why import a new component (i.e., FC ) if you can directly specify...

Hi @AgniveshChaubey, any updates over here?

> `implementation.fetchVersionedReportsFor` I don't right away see this having an n^3 time complexity. Can you point out exactly how/where ?. All the JSON files are being fetched concurrently using `Promise.all`.

> the versions.map(...) loop inside fetchVersionedReportsFor and the two nested loops inside prepareVersionsComplianceReportFor collectively makes the time complexity n^3. I just optimized it a bit. Can you have a look...

> I think it's possible to reduce the time complexity to the order of O(n). I'm working on it. I'll update you as soon as I find a way! Okay....

> Sure, I'll take care of that. > Right now you have used fetchVersionedReportsFor function in the VersionsTrens.tsx component only, right? I just optimized it even further @AgniveshChaubey. Can you...