audiobookshelf icon indicating copy to clipboard operation
audiobookshelf copied to clipboard

Published 20 hours ago • verified publisher icon advplyr

Migrate to new pdf viewer

Open vincentscode opened this issue 1 year ago • 4 comments

This is an attempt to resolve #2279. It should retain all the functionality of the current viewer but also resolve the issues outlined there. The styling isn't perfect yet, but i've been unable to produce a "nice" solution to that, yet.

vincentscode avatar Dec 31 '23 17:12 vincentscode

Wonder if you should look into implementing this instead for your PR?

https://github.com/johnfactotum/foliate-js

gh0sti avatar Mar 15 '24 20:03 gh0sti

@gh0sti Is there any reason for switching? It does not seem to have any integration with vue.

vincentscode avatar Mar 16 '24 07:03 vincentscode

@gh0sti Is there any reason for switching? It does not seem to have any integration with vue.

I saw in discord chat dev channel some of the devs mentioning it.

gh0sti avatar Mar 28 '24 02:03 gh0sti

@advplyr would you mind taking a look at this so it may be merged? :)

vincentscode avatar May 09 '24 11:05 vincentscode

I checked this out and merged master. Scaling doesn't work properly. It doesn't load the current page because it is listening to the wrong event, should be @loading.

This library is abandoned like the one currently used. It is probably worth looking for a library that is up-to-date. I think we also need a pdf worker.js file to use with pdf.js. I saw a warning in the console about this but haven't spent a lot of time on it due to the library being abandoned and the issues I mentioned above.

advplyr avatar May 31 '24 20:05 advplyr