qbit icon indicating copy to clipboard operation
qbit copied to clipboard

afterMethodCallOnServiceQueue is not called after service method call

Open lijishuai opened this issue 8 years ago • 4 comments

setAfterMethodCallOnServiceQueue(..) , but not called. I find the problem in function BaseServiceQueueImpl.doHandleMethodCall(...) If the service method return ServiceConstants.VOID , afterMethodCall will be lost. I think something is wrong when I set afterMethodCall... but not be invoked. I find the receiver handler of ServiceQueue's responseQueue does not invoke afterMethodCall in function CallbackManagerWithTimeout's method handleResponse(...) thanks.

lijishuai avatar Sep 05 '16 11:09 lijishuai

Do you want to try a patch? PR?

RichardHightower avatar Sep 12 '16 08:09 RichardHightower

I can do it, but maybe after some days. because I'm very busy on work now. so ... I have some other advice on sync -> async call when refactor old sync source code. will new a issue.

lijishuai avatar Sep 28 '16 01:09 lijishuai

Ok.. Sounds good. I look forward to the PR. Thanks for using QBit and keep the feedback coming.

RichardHightower avatar Sep 30 '16 01:09 RichardHightower

If you don't have time for a PR, try at least a code sample or unit test that shows the problem.

RichardHightower avatar Sep 30 '16 01:09 RichardHightower