arc-electron icon indicating copy to clipboard operation
arc-electron copied to clipboard

Uploading non-ASCII file name in multipart does not work correctly.

Open trajano opened this issue 5 years ago • 2 comments

According to the spec https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition specifically filename* utf8 encoded filenames has to be sent with the encoding information in the filename* field. In addition. filename alone is expected to be in US-ASCII format.

What's happening right now is the filename is sent as blob rather than the original file name. As such I cannot upload a file with non-ASCII characters

Expected outcome

Uploading a file フェニックス.jpg should result in

Content-Disposition: form-data; name="uploadFile"; filename*=UTF-8''%E3%83%95%E3%82%A7%E3%83%8B%E3%83%83%E3%82%AF%E3%82%B9.jpg

Actual outcome

Content-Disposition: form-data; name="uploadFile"; filename="ãã§ããã¯ã¹.jpg"

Versions

App: 12.1.4 Platform: win32 Electron: 2.0.2 Chrome: 61.0.3163.100 V8: 6.1.534.41 Node: 8.9.3

Steps to reproduce

Similar to https://github.com/postmanlabs/postman-app-support/issues/5912

trajano avatar Feb 12 '19 17:02 trajano

Hi, thank you for the issue report. Sorry for taking it so long. I was in the middle of rewriting the whole app to support new features in the future.

ARC is using an external library to process form data. I created an issue in this library to add support for the filename* parameter in the part message. Once it's patched there it will be updated in ARC as well.

jarrodek avatar Feb 07 '21 20:02 jarrodek

This issue has been automatically marked as stale because it has not had recent activity and is not currently prioritized. It will be closed in a week if no further activity occurs :)

stale[bot] avatar Feb 12 '22 03:02 stale[bot]