vue-advanced-chat icon indicating copy to clipboard operation
vue-advanced-chat copied to clipboard

Allow user to specify different colors for own messages and their timestamps.

Open j4hangir opened this issue 2 years ago • 4 comments

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [X] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [X] No

j4hangir avatar Oct 26 '22 21:10 j4hangir

Could you please checkout the dist files? I will update those for the next release

antoine92190 avatar Oct 30 '22 13:10 antoine92190

Could you please checkout the dist files? I will update those for the next release

I think it's through, although one more thing is missing which is the me color for timestamps.

BTW I think it would've been much more convenient to use CSS parts, allow people to apply their css without the hassle of defining each and every variable.

j4hangir avatar Oct 30 '22 18:10 j4hangir

I've replaced the audio recorder with capacitor-voice-recorder which is also web-friendly allowing iOS to use VAC as well.

I've merely replaced the relevant parts in recorder.js and did some patching with Audio/Video detection code - which on a side-note is quite bug-prone! - but it works nicely so far, although replacing hardcoded .mp3 with .wav will cause problems down the line.

Please have a look and if you approve of this direction I'll tidy up and get rid of the old one completely.

j4hangir avatar Nov 08 '22 21:11 j4hangir

This looks promising, but it's very difficult to see the code changes as your code formatting tool changed indentation.

  • Could you revert the code formatting changes and the dist files so it's easier to read?
  • It would be nice to create another PR as this one should only focus on message color and timestamp.

antoine92190 avatar Nov 09 '22 08:11 antoine92190