wasm4 icon indicating copy to clipboard operation
wasm4 copied to clipboard

Add Gas to devtools view

Open JerwuQu opened this issue 3 years ago • 3 comments

JerwuQu avatar Aug 19 '22 14:08 JerwuQu

I see that there are some conflicts now. @aduros is this PR interesting? If so I could fix them, otherwise I'll close it.

JerwuQu avatar Oct 25 '23 11:10 JerwuQu

Hey, sorry this fell through the cracks. I like the approach you took and think it would make a great opt-in experiment. If you fix the conflicts I'll merge it 🙂 Please also add:

  1. Let's always show the gas section on the developer tools. If --metering was not used, it should tell the user about the --metering option to enable this feature.
  2. Add some more documentation, either on the site, in the devtools, or a more descriptive --metering help description.

Thanks!

aduros avatar Nov 15 '23 18:11 aduros

I resolved the conflicts for now, but it seems like the wasm-metering package itself might be broken for WASM files using newer features. For example, it works on wasm4nia but throws an exception on Mr.Rafael's Sound Test. I suspect this is due to bulk-memory extensions, but I haven't actually checked if that WASM file uses them.

A closer look and the repo is clearly orphaned, so it shouldn't come as a surprise. Either I'd have to fork it and bring it up to date, or we have to put this PR on ice until someone else does so.

EDIT: Changed this PR into a draft until someone forks the project or creates an alternative.

JerwuQu avatar Dec 29 '23 11:12 JerwuQu